[Buildbot-devel] [RFC] enhancements to buildbots repo/gerrit support

Aurelien Bompard aurelien at bompard.org
Sat Jul 9 07:13:53 UTC 2011

> > e6be01d status_gerrit: add global status in the callback    <-- this
> > one changes API
> not merged - see comment

I'm using Gerrit with Buildbot too, and I had a similar issue (or at least I 
think it's similar): a change in Gerrit may trigger several builds, so 
GerritStatusReceiver will add several "success" or "failure" comments to the 
change, the latest verified flag overwriting the others.

I think GerritStatusReciever should subscribe to the buildset instead of the 
build, pretty much like MailNotifier does in summary mode.
I have subclassed GerritStatusReceiver on my install to do that and it works 
fine, but maybe that's only my use-case ?
Pierre (or other Gerrit users), what do you think ?

http://aurelien.bompard.org    ~~~~~~    jabber: aurelien at bompard.org
"Between stimulus and response there's a space, in that space lies
our freedom." -- Viktor Frankl

More information about the devel mailing list