[Buildbot-devel] [RFC] enhancements to buildbots repo/gerrit support

Dustin J. Mitchell dustin at v.igoro.us
Fri Jul 8 23:46:01 UTC 2011

On Thu, Jun 30, 2011 at 10:06 AM, Pierre Tardy <tardyp at gmail.com> wrote:
> first patches are fixes (ready for merge):
> 0b30fe gerritchangesource: use gerrit's changeid as the branch
> 3f8623f status_gerrit: replace quotes by double quotes in message
> 98467ea Trigger: dont fail if copied property does not exist
all merged

> 32886a0 slave/repo: do repo sync twice
not merged - see comment

> e57679f slave/repo: dont clobber if cherry-pick fails
> ad586c2 slave/repo: reset the tree in case some cherry-picked failed before

> Then you got some customizability patches (ready for merge):
> e6be01d status_gerrit: add global status in the callback    <-- this one
> changes API
not merged - see comment

> 73f8c04 gerritchangesource: factorize to allow subclassing
> 2b9d699 repo_source: added buildDownloadList method

> Then there is a RFC only patch, not for merge.
> 4fa04d3 [RFC] Simplify the forced build system

I like this change, but it is a significant end-user-visible change.
Given that nobody else has responded to the RFCs, it's hard to justify
such a change.  Is there a way to still support the old behavior,
maybe with a conditional in the templates?


More information about the devel mailing list