[Buildbot-devel] Sphinx builder
Dustin J. Mitchell
dustin at v.igoro.us
Thu Aug 4 14:51:33 UTC 2011
2011/8/3 Benoît Allard <benoit at aeteurope.nl>:
> About the buildstep, I'd have loved to integrate it to the testsuite, but
> after adding my tenth Mock object I also gave up. I guess, I missed
> something ... maybe you should first put a template on how to add a
> testsuite for a ShellCommand step ... I'd use that one ...
You should be able to look at test_steps_shell.py for examples of step
tests. That has all of the necessary mocks and fakes put together
already, including for commands sent to the slave.
As to the draft, I think you may have namespace collisions with
self.builder and self.builddir. Maybe those attributes could be
self.sphinx_builder and self.sphinx_builddir? (They're also
pronounced nearly identically, at least in my speech, but that is
Beyond that, this looks fine - looking forward to seeing your patch on github.
More information about the devel