[Buildbot-devel] insufficient args for _substantiate in buildbot.py/detached

[johnmcarr]

Hi Ben,

Can you see if this patch works for you?

https://github.com/Jc2k/buildbot/commit/2d09b053a661251072fb4546b86a765ed95791e5

This will give any other calls to _substantiate the same build object that was used originally. The cached reference is removed
 whenever substantiation_deferred is unset.

If it works for you I'll send a pull request.

John

On 23 Apr, 2011,at 08:54 AM, Ben Clifford <benc at hawaga.org.uk> wrote:

>
> _substantiate is called in buildbot.py detached() (around line 20) with no
> parameter, but since around ddd63b51 that has needed a build parameter.
>
> This breaks the ssh latent build slave that I've been hacking on. As I do
> not use the build parameter, I stuck a dummy value in but that's presumbly
> not the right thing to do
>
> The situation which makes this happen for me: my build slave
> desubstantiates after each build, which means that the next build for that
> slave often uses the substantiation_deferred mechanism.
>
> (commit ids: In present head f48c37c0a51d11434a4ac66d75275b33b62b3eea,
> possibly introduced in ddd63b511ed59e2df9c2a8f41ecabd8b3c99b469.)
>
> Ben
>
> -- 
> http://www.hawaga.org.uk/ben/
>
> ------------------------------------------------------------------------------
> Fulfilling the Lean Software Promise
> Lean software platforms are now widely adopted and the benefits have been
> demonstrated beyond question. Learn why your peers are replacing JEE
> containers with lightweight application servers - and what you can gain
> from the move. http://p.sf.net/sfu/vmware-sfemails
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20110423/6686935f/attachment.html>