[Buildbot-devel] insufficient args for _substantiate in buildbot.py/detached

Ben Clifford benc at hawaga.org.uk
Sat Apr 23 07:54:00 UTC 2011


_substantiate is called in buildbot.py detached() (around line 20) with no 
parameter, but since around ddd63b51 that has needed a build parameter.

This breaks the ssh latent build slave that I've been hacking on. As I do 
not use the build parameter, I stuck a dummy value in but that's presumbly 
not the right thing to do.

The situation which makes this happen for me: my build slave 
desubstantiates after each build, which means that the next build for that 
slave often uses the substantiation_deferred mechanism.

(commit ids: In present head f48c37c0a51d11434a4ac66d75275b33b62b3eea, 
possibly introduced in ddd63b511ed59e2df9c2a8f41ecabd8b3c99b469.)

Ben

-- 
http://www.hawaga.org.uk/ben/




More information about the devel mailing list