[Buildbot-devel] WebStatus: why is WebStatus object accessed by request.site.buildbot_service in resources?

[Dustin J. Mitchell]

On Thu, Mar 4, 2010 at 9:36 AM, Dave Piche <dpiche at plantcml-eads.com> wrote:
> The problem I see with this mechanism is that multiple WebSatus object (each
> deserving a different BuildMaster) can not share the same Site object
> (because every WebStatus “overwrite” the site.buildbot_service argument).

This isn't a common use-case..

> I think it would be better to just pass a referenced of the WebStatus to
> each resource that WebStatus used (WaterfallStatusResource,
> GridStatusResource, ConsoleStatusResource, etc.).

..but if the changes to support this use are minimal and you provide a
patch (or a fork on github), I'll be happy to merge something to
support it.

Would it be easier to attach a reference to the site -- or to the
BuildMaster itself, maybe -- to the request object as it traverses the
root of the WebStatus object?

Dustin

-- 
Open Source Storage Engineer
http://www.zmanda.com