[Buildbot-devel] WebStatus: why is WebStatus object accessed by request.site.buildbot_service in resources?

[Dave Piche]

Hi All,

 

In the WebStatus constructor, we explicitly put a self-referenced in the Site object (site.buildbot_service) that resources can accessed from Request object (request.site.buildbot_service) to retrieved build status.

 

The problem I see with this mechanism is that multiple WebSatus object (each deserving a different BuildMaster) can not share the same Site object (because every WebStatus "overwrite" the site.buildbot_service argument).

 

I think it would be better to just pass a referenced of the WebStatus to each resource that WebStatus used (WaterfallStatusResource, GridStatusResource, ConsoleStatusResource, etc.).

 

Thanks

 

 

Dave Piché

Software Developer Student 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20100304/efac830f/attachment.html>