[Buildbot-devel] Changeset display order in waterfall versus T-Grid

Stefan Seefeld seefeld at sympatico.ca
Fri Jul 23 19:49:05 UTC 2010


  On 07/23/2010 03:33 PM, Dustin J. Mitchell wrote:
> On Fri, Jul 23, 2010 at 1:31 PM, Iustin Pop<iustin at google.com>  wrote:
>> Would it make sense to either modify T-Grid to accept a parameter for
>> this, or maybe to reverse the sort order permanently as to match the
>> Waterfall one?
> I hate to be the crotchety old man on this issue, but this is a case
> where everyone wants slightly different things.
>
> The web display configuration is not really amenable to adding
> configuration knobs for every tweak, since they must go in at the
> toplevel (WebStatus constructor).

Can't this order reversal be achieved by some template tweaks ? Right 
now the appropriate loop is in grid.html, and it reads

   for build in builder.builds

Can't this be customized to something like

  for build in reverse(builder.builds)

? In fact, even the distinction between grid and tgrid should be merely 
a matter of a changed template. Ideally, users could add arbitrary new 
views, which then could be requested from an appropriate URL from which 
the template name is extracted.

At least, I believe this kind of customization was the entire idea 
behind the switch to jinja2 templates.

     Stefan

-- 

       ...ich hab' noch einen Koffer in Berlin...





More information about the devel mailing list