[Buildbot-devel] Getting the builder names for the try scheduler?

[Brad Hards]

On Monday 04 January 2010 02:55:19 Dustin J. Mitchell wrote:
> On Sun, Jan 3, 2010 at 12:31 AM, Brad Hards <bradh at frogmouth.net> wrote:
> > Attached is the patch that does the server side and client side parts.
> 
> Looks pretty good. Needs docs.
What is it about documentation that makes me put off doing patches...

Included in updated patch - attached.

> Check your indentation:
> +    def getAvailableBuilderNames(self):
> +   return self.builderNames
Indeed. Tab instead of spaces. I'm blaming my editor for this one.

> I'd rather this pretty-printed the names somehow - maybe one per line?
> +    def _getBuilderNames2(self, buildernames):
> +        print "The following builders are available for the try scheduler:
>  " +        print buildernames
Fixed to be one per line. The alternative would be to join the list, but it 
might look really bad with a longer list.

Brad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: try-buildernames-2010-01-05.patch
Type: text/x-patch
Size: 5313 bytes
Desc: not available
URL: <http://buildbot.net/pipermail/devel/attachments/20100105/6978d2c0/attachment.bin>