[Buildbot-devel] Getting the builder names for the try scheduler?

Dustin J. Mitchell dustin at zmanda.com
Sun Jan 3 15:55:19 UTC 2010


On Sun, Jan 3, 2010 at 12:31 AM, Brad Hards <bradh at frogmouth.net> wrote:
> Attached is the patch that does the server side and client side parts.

Looks pretty good. Needs docs.

Check your indentation:
+    def getAvailableBuilderNames(self):
+   return self.builderNames

I'd rather this pretty-printed the names somehow - maybe one per line?
+    def _getBuilderNames2(self, buildernames):
+        print "The following builders are available for the try scheduler: "
+        print buildernames

That's about it.  Testing Buildbot is often more trouble than the
initial patch, and maintaining such tests is a significant part of the
Buildbot maintenance burden, so if this works, I'm happy to call it a
good and merge it (with docs and the above fixes).

Dustin

-- 
Open Source Storage Engineer
http://www.zmanda.com




More information about the devel mailing list