[Buildbot-devel] console does not match waterfall for older builds (0.7.12 + CSS fix; SVN)

[Aviv Ben-Yosef]

This is the suggested fix Charles checked for me.

diff --git a/buildbot/status/web/console.py b/buildbot/status/web/console.py
index 1b83214..2ea1f21 100755
--- a/buildbot/status/web/console.py
+++ b/buildbot/status/web/console.py
@@ -302,7 +302,7 @@ class ConsoleStatusResource(HtmlResource):

                 # Now break if we have enough builds.
                 current_revision = self.getChangeForBuild(
-                    builder.getBuild(-1), revision)
+                    build, revision)
                 if self.comparator.isRevisionEarlier(
                     devBuild, current_revision):
                     break


On Tue, Feb 9, 2010 at 05:08, Dustin J. Mitchell <dustin at zmanda.com> wrote:

> On Mon, Feb 8, 2010 at 6:10 PM, Nicolas Sylvain <nsylvain at chromium.org>
> wrote:
> > Aviv suggested we replace "builder.getBuild(-1)" by  "build", which is
> > slightly
> > more correct from an integer-based point of view. I believe it should
> work
> > for non-integer too.  Not sure if charles was going to try it or not.
>
> I'm sorry, I'm not following the prose-form patching well enough.
> What's the change being suggested here?  Can you paste in a diff for
> me?
>
> Dustin
>
> --
> Open Source Storage Engineer
> http://www.zmanda.com
>



-- 
Aviv Ben-Yosef
Miracle Max: You rush a miracle man, you get rotten miracles.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20100209/a6284c33/attachment.html>