[Buildbot-devel] console does not match waterfall for older builds (0.7.12 + CSS fix; SVN)
aviv.by at gmail.com
Tue Feb 9 06:17:12 UTC 2010
This is the suggested fix Charles checked for me.
diff --git a/buildbot/status/web/console.py b/buildbot/status/web/console.py
index 1b83214..2ea1f21 100755
@@ -302,7 +302,7 @@ class ConsoleStatusResource(HtmlResource):
# Now break if we have enough builds.
current_revision = self.getChangeForBuild(
- builder.getBuild(-1), revision)
+ build, revision)
On Tue, Feb 9, 2010 at 05:08, Dustin J. Mitchell <dustin at zmanda.com> wrote:
> On Mon, Feb 8, 2010 at 6:10 PM, Nicolas Sylvain <nsylvain at chromium.org>
> > Aviv suggested we replace "builder.getBuild(-1)" by "build", which is
> > slightly
> > more correct from an integer-based point of view. I believe it should
> > for non-integer too. Not sure if charles was going to try it or not.
> I'm sorry, I'm not following the prose-form patching well enough.
> What's the change being suggested here? Can you paste in a diff for
> Open Source Storage Engineer
Miracle Max: You rush a miracle man, you get rotten miracles.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the devel