[Buildbot-devel] console does not match waterfall for older builds (0.7.12 + CSS fix; SVN)

[Charles Lepple]

On Feb 8, 2010, at 7:10 PM, Nicolas Sylvain wrote:

> On Mon, Feb 8, 2010 at 3:40 PM, Dustin J. Mitchell  
> <dustin at zmanda.com> wrote:
> On Sun, Feb 7, 2010 at 9:48 PM, Nicolas Sylvain  
> <nsylvain at chromium.org> wrote:
> > I also tried on my master (who seemed to have started to act badly  
> today
> > too), and it also worked.
> > +aviv: In case you know what the real fix should be.
>
> It doesn't look like this fix will work for non-integer revisions (in
> fact, it's sorting revisions lexically if I'm not mistaken, so it will
> even be wrong for SVN every once in a while).
>
> But this does narrow down the problem to isRevisionEarlier, right?
> Aviv?  Any ideas?
>
> Aviv suggested we replace "builder.getBuild(-1)" by  "build", which  
> is slightly
> more correct from an integer-based point of view. I believe it  
> should work
> for non-integer too.  Not sure if charles was going to try it or not.

Just had a chance to try it with "build" - that seems to work as well.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20100208/2ce95668/attachment.html>