[Buildbot-devel] Windows TLC needed

[Marcus Lindblom]

On 2010-02-01 22:48, Marc-Antoine Ruel wrote:
> 2010/2/1 Marcus Lindblom<macke at yar.nu>:
>> On 2010-02-01 22:38, Marc-Antoine Ruel wrote:
>>>
>>> 2010/2/1 Marcus Lindblom<macke at yar.nu>:
>>>
>>>>
>>>> On 2010-02-01 22:33, Marc-Antoine Ruel wrote:
>>>>
>>>>>
>>>>> 2010/2/1 Marcus Lindblom<macke at yar.nu>:
>>>>>
>>>>>
>>>>>>
>>>>>> I just remembered that I think the old Twisted wart might be
>>>>>> responsible
>>>>>> for some problems here. The issue is, IIRC, that Twisted doesn't shut
>>>>>> down process trees on Windows properly.
>>>>>>
>>>>>>
>>>>>
>>>>> We use a hackish workaround for that, search for "taskkill" in
>>>>>
>>>>>
>>>>> http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/pylibs/twisted/internet/_dumbwin32proc.py?view=markup

> Definitely. We were just not used to patch at runtime. If we can come
> up with something better, it'd be better to upstream it to twisted but
> this has been "fine enough" for us.

In addition to 'taskkill', there is also 'pskill' from sysinternals that 
is now distributed by Microsoft.

Either could work, unless we get the proper 'Job API' fix in there.

Cheers,
/Marcus