[Buildbot-devel] Windows TLC needed

[Marcus Lindblom]

On 2010-02-01 22:38, Marc-Antoine Ruel wrote:
> 2010/2/1 Marcus Lindblom<macke at yar.nu>:
>    
>> On 2010-02-01 22:33, Marc-Antoine Ruel wrote:
>>      
>>> 2010/2/1 Marcus Lindblom<macke at yar.nu>:
>>>
>>>        
>>>> I just remembered that I think the old Twisted wart might be responsible
>>>> for some problems here. The issue is, IIRC, that Twisted doesn't shut
>>>> down process trees on Windows properly.
>>>>
>>>>          
>>> We use a hackish workaround for that, search for "taskkill" in
>>>
>>> http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/pylibs/twisted/internet/_dumbwin32proc.py?view=markup
>>>
>>> You can diff it with
>>>
>>> http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/pylibs/twisted/internet/_dumbwin32proc_orig.py?view=markup
>>> to get the exact changes.
>>>
>>>        
>> That file has only one revision?
>>
>>      
> No, it's just changes that occurred before I finally decided to open
> source the build infrastructure aren't visible externally.
>    
Ah. I misunderstood the links. Sorry. Will look.

I wonder if we can monkey-patch twisted from buildbot to fix this?

/Marcus