[Buildbot-devel] Windows TLC needed

[Marc-Antoine Ruel]

2010/2/1 Marcus Lindblom <macke at yar.nu>:
> On 2010-02-01 22:33, Marc-Antoine Ruel wrote:
>>
>> 2010/2/1 Marcus Lindblom<macke at yar.nu>:
>>
>>>
>>> On 2010-02-01 17:37, Dustin J. Mitchell wrote:
>>>
>>>>
>>>> I think we would all like to have buildbot 0.8.0 work much better on
>>>> Windows.
>>>>
>>>> So please, if you have some windows experience, can you jump in and help
>>>> out?
>>>>
>>>
>>> I just remembered that I think the old Twisted wart might be responsible
>>> for some problems here. The issue is, IIRC, that Twisted doesn't shut
>>> down process trees on Windows properly.
>>>
>>
>> We use a hackish workaround for that, search for "taskkill" in
>>
>> http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/pylibs/twisted/internet/_dumbwin32proc.py?view=markup
>>
>> You can diff it with
>>
>> http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/pylibs/twisted/internet/_dumbwin32proc_orig.py?view=markup
>> to get the exact changes.
>>
>
> That file has only one revision?
>
> /Marcus
>

No, it's just changes that occurred before I finally decided to open
source the build infrastructure aren't visible externally.

M-A