[Buildbot-devel] [PATCH] make /path/to/build?numbuilds=123 work

[Ian Zimmerman]

Dustin J. Mitchell wrote:
> This looks good.  I have a few suggestions:
> 
> 1.  If possible, this should have some tests.  See buildbot/test/test_web.py
> 

Well, I will look at that, but last time I tried I was totally confused 
by the enormous testing infrastructure.

> 2. This definitely needs to be documented -- both the URL query
> parameter and the new WebStatus keyword argument.
> 
> 3. The name 'recentbuilds' for the WebStatus argument doesn't indicate
> its use very well.  How about changing it to "num_recent_builds"
> universally?

Do you mean just the code variables, or the URL arguments too?  In that 
case, should the existing (but dysfunctional as it is) 
/one_line_per_build?numbuilds=  change too?

i