[Buildbot-devel] [PATCH] make /path/to/build?numbuilds=123 work

Dustin J. Mitchell dustin at zmanda.com
Thu Mar 12 22:57:18 UTC 2009


This looks good.  I have a few suggestions:

1.  If possible, this should have some tests.  See buildbot/test/test_web.py

2. This definitely needs to be documented -- both the URL query
parameter and the new WebStatus keyword argument.

3. The name 'recentbuilds' for the WebStatus argument doesn't indicate
its use very well.  How about changing it to "num_recent_builds"
universally?

Dustin

-- 
Storage Software Engineer
http://www.zmanda.com




More information about the devel mailing list