[Buildbot-devel] Blamelist includes non-important changes?

Greg Ward gerg.ward+buildbot at gmail.com
Fri Mar 6 18:44:21 UTC 2009


On Fri, Mar 6, 2009 at 9:46 AM, Axel Hecht <l10n.moz at googlemail.com> wrote:
> I ended up subclassing the scheduler to get rid of that behaviour.

OK thanks.  Now at least I know where to start.  ;-)

> I'm not actually sure why the behaviour is as is, though.

Probably because it makes sense for Buildbot's canonical use case,
where you're building one project from one repository and most commits
are important.  I imaging the original intention behind
fileIsImportant() is so that, say, changes to README.txt and
doc/*.html do not trigger builds.  As usual, I'm perverting Buildbot
well outside of its original design, and as usual it's holding up
pretty well with the occasional minor nit that can be worked around by
careful subclassing.

Greg




More information about the devel mailing list