[Buildbot-devel] Resubmitted builds do not include properties set at trigger time
dbailey at hp.com
Tue Jun 16 17:01:26 UTC 2009
> -----Original Message-----
> From: chris.atlee at gmail.com [mailto:chris.atlee at gmail.com] On
> Behalf Of Chris AtLee
> Sent: 16 June 2009 15:49
> To: Dustin J. Mitchell
> Cc: Bailey, Darragh; buildbot-devel at lists.sourceforge.net
> Subject: Re: [Buildbot-devel] Resubmitted builds do not
> include properties set at trigger time
> On Tue, Jun 16, 2009 at 9:54 AM, Dustin J.
> Mitchell<dustin at zmanda.com> wrote:
> > On Tue, Jun 16, 2009 at 8:23 AM, Bailey,
> Darragh<dbailey at hp.com> wrote:
> >> Looking at maybe using the property source information to
> determine which ones to copy. Properties passed in via a
> trigger scheduler will have have the source set as "Trigger",
> so it may be sufficient simply to copy through only
> properties that match this source. Copying all properties is
> probably a bad idea, so I need some sort of limiter.
> >> Can anyone else suggest whether there might any other ways
> to filter which properties should be copied through when
> resubmitting a build?
> I've done some initial work on having properties live on Change
> objects as well. The motivation behind this is to be able to rebuild
> builds that had properties set via custom schedulers. Would this work
> for you?
> > I don't like this idea much at all -- that source info is just meant
> > as a user-level debugging aid (since there are a half-dozen places
> > properties can come from).
I didn't like it either, but I needed a quick fix to allow me to be able to resubmit a triggered build so that I could easily find out what was broken in a build here.
> > The Right solution here is to save the original build request and
> > submit a copy of it on a rebuild request.
> I agree here. If buildbot is letting you set properties on requests,
> then it should preserve those properties on a rebuild.
Haven't looked at the solution closely, but given the intention is to be able to rebuild builds that had properties set via custom schedulers, I imagine that it should work. :)
Systems Software Engineer
Hewlett Packard Galway Ltd.
Postal Address: Hewlett Packard Galway Limited, Ballybrit Business Park, Galway
Registered Office: Hewlett Packard Galway Limited, 63-74 Sir John Rogerson's Quay Dublin 2
Registered Number: 361933
More information about the devel