[Buildbot-devel] Resubmitted builds do not include properties set at trigger time
chris at atlee.ca
Tue Jun 16 14:49:09 UTC 2009
On Tue, Jun 16, 2009 at 9:54 AM, Dustin J. Mitchell<dustin at zmanda.com> wrote:
> On Tue, Jun 16, 2009 at 8:23 AM, Bailey, Darragh<dbailey at hp.com> wrote:
>> Looking at maybe using the property source information to determine which ones to copy. Properties passed in via a trigger scheduler will have have the source set as "Trigger", so it may be sufficient simply to copy through only properties that match this source. Copying all properties is probably a bad idea, so I need some sort of limiter.
>> Can anyone else suggest whether there might any other ways to filter which properties should be copied through when resubmitting a build?
I've done some initial work on having properties live on Change
objects as well. The motivation behind this is to be able to rebuild
builds that had properties set via custom schedulers. Would this work
> I don't like this idea much at all -- that source info is just meant
> as a user-level debugging aid (since there are a half-dozen places
> properties can come from).
> The Right solution here is to save the original build request and
> submit a copy of it on a rebuild request.
I agree here. If buildbot is letting you set properties on requests,
then it should preserve those properties on a rebuild.
More information about the devel