[Buildbot-devel] Python2.3 compatibility

[Bailey, Darragh]

> -----Original Message-----
> From: Jean-Paul Calderone [mailto:exarkun at divmod.com] 
> Sent: 10 June 2009 15:52
> To: Bailey at domain.invalid; Bailey, Darragh; 
> buildbot-devel at lists.sourceforge.net
> Subject: Re: [Buildbot-devel] Python2.3 compatibility

<snipped>

> 
> First, the test is clearly buggy.  
> `self.failUnless(len(content), 512)´
> should obviously be `self.assertEquals(len(content), 512)´.  
> Likewise for
> the 1024 line.  As for why the test is failing for you on 
> Python 2.3 but
> not on Python 2.4, though, I don't really know.
> 
> Jean-Paul
> 

I'm not so certain that it's a problem with python 2.4 v's 2.3. I have a nagging feeling that the compression and file writeout isn't complete when the verification step goes to try and open the file up again. Which results in it getting an empty file (len(content)==0), and the file contents appear perfectly fine when viewing the filesystem a few seconds later.

Just spotted the following line in the output:
===============================================================================
[SKIPPED]: buildbot.test.test_limitlogs.MasterLogs.testLog

Twisted 8.2.0 or higher required

Wondering if perhaps the same problem exists here? Testing of log compression but twisted isn't new enough to handle it correctly. Might be time for me to upgrade.

--
Regards,
Darragh Bailey

Systems Software Engineer
Hewlett Packard Galway Ltd.

Postal Address:    Hewlett Packard Galway Limited, Ballybrit Business Park, Galway
Registered Office: Hewlett Packard Galway Limited, 63-74 Sir John Rogerson's Quay Dublin 2
Registered Number: 361933