[Buildbot-devel] Python2.3 compatibility

Jean-Paul Calderone exarkun at divmod.com
Wed Jun 10 14:51:44 UTC 2009

On Wed, 10 Jun 2009 13:20:09 +0000, "Bailey, Darragh" <dbailey at hp.com> wrote:
>Having to do a bit of work to get everything in buildbot working with python 2.3. As part os this I've been going through the test sweet and fixing up where errors are occuring due to use of python 2.4 constructs (i.e. set is internal to 2.4, but is accessible only via sets.Set module in 2.3).
>I've gotten to the stage where all except 1 of the tests that are run (few skipped due to software not installed such as mercurial/git/bzr/etc..) is still failing.
>This is the compress logs test. I've added a message to the output to make it easier to see what is going on, hopefully someone can point me towards the source of the issue.
>  CompressLog
>    testCompressLogs ... Failure: twisted.trial.unittest.FailTest: compressed log is not expected size, got 0, expected 1024
>Previously it just used to say "testCompressLogs ... Failure: twisted.trial.unittest.FailTest: 1024" which wasn't very helpful.
>Now looking for the output:
>ls -la _trial_temp/test-compress/buildername/1-log-foostep-to-compress.bz2
>-rw-r--r--  1 darragh man 56 Jun 10 13:43 _trial_temp/test-compress/buildername/1-log-foostep-to-compress.bz2
>The file is there and it's contents appear to be correct as well (based on the contents of the not-compress log file):
> bzcat _trial_temp/test-compress/buildername/1-log-foostep-to-compress.bz2

First, the test is clearly buggy.  `self.failUnless(len(content), 512)´
should obviously be `self.assertEquals(len(content), 512)´.  Likewise for
the 1024 line.  As for why the test is failing for you on Python 2.3 but
not on Python 2.4, though, I don't really know.


More information about the devel mailing list