[Buildbot-devel] Bug 187 (Re: Buildbot-0.7.10!)

[Marcus Lindblom]

Marcus Lindblom wrote:
> Axel Hecht wrote:
>> 2009/1/19 Marcus Lindblom <macke-DIcC8dYblPE-XMD5yJDbdMReXY1tMh2IBg at public.gmane.org 
>> <mailto:macke-DIcC8dYblPE-XMD5yJDbdMReXY1tMh2IBg at public.gmane.org>>
>>
>>     I'm stuck on bug 187 (support inrepo branches for Mercurial) as the
>>     checkoutHTTP-test fails. I've no idea how to debug the 'dirty reactor'
>>     error message.
>>
>>     Tips here would be welcome.
>>
>> I pulled your bug187 branch (I think), and I could only reproduce your 
>> error once. My guess is that you're stopping the trial process before 
>> the hg serve process is down. I'd suggest to:
>>
>> add processEnded to MercurialPP, making that notify the TestCase. 
>> Something like a deferred. And to return that from tearDown2.
>>
>> Just guessing, as I only reproduced this once, and of course, I don't 
>> have the logs of that anymore. Adding a log.msg to processEnded would 
>> make things clearer still.
> 
> Thx. I'll have a look.

You were right on the spot! I managed to a callback and all that, and 
now it works. (Asynchronous is fun.. albeit confusing. :)

The wierd thing was that when I enable defered debugging, it works. (As 
I've noted in the ticket.) I hate those Heisenbugs.

I'll do some final testing and push the changes onto github.

Cheers,
/Marcus