[Buildbot-devel] Bug 187 (Re: Buildbot-0.7.10!)

[Marcus Lindblom]

Axel Hecht wrote:
> 2009/1/19 Marcus Lindblom <macke at yar.nu 
> <mailto:macke at yar.nu>>
> 
>     I'm stuck on bug 187 (support inrepo branches for Mercurial) as the
>     checkoutHTTP-test fails. I've no idea how to debug the 'dirty reactor'
>     error message.
> 
>     Tips here would be welcome.
> 
> I pulled your bug187 branch (I think), and I could only reproduce your 
> error once. My guess is that you're stopping the trial process before 
> the hg serve process is down. I'd suggest to:
> 
> add processEnded to MercurialPP, making that notify the TestCase. 
> Something like a deferred. And to return that from tearDown2.
> 
> Just guessing, as I only reproduced this once, and of course, I don't 
> have the logs of that anymore. Adding a log.msg to processEnded would 
> make things clearer still.

Thx. I'll have a look.

> I ran your tests on both 1.1 and 0.9.5, any idea why 1.1 would take 
> twice as long to run through all 5 Mercurial tests? Almost a minute 
> compared to less than a half on my mac.

Not really. I did some refactoring to avoid excessive re-cloning on 
branch-switch at the same time. (It felt like the simplest solution at 
the time.)

I'll see if I can do some profiling as well.

Cheers,
/Marcus