[Buildbot-devel] Bug 187 (Re: Buildbot-0.7.10!)

[Axel Hecht]

2009/1/19 Marcus Lindblom <macke at yar.nu>

> Dustin J. Mitchell wrote:
> > Folks, the time is drawing near to release Buildbot-0.7.10.
> >
> > If you have changes you'd like to see included, get 'em in now -- git
> > branches are preferred, but patches on Trac or here in email are fine,
> > too.  Trac issues with patches for review should have the "review"
> > keyword.
>
> I'm stuck on bug 187 (support inrepo branches for Mercurial) as the
> checkoutHTTP-test fails. I've no idea how to debug the 'dirty reactor'
> error message.
>
> Tips here would be welcome.
>

I pulled your bug187 branch (I think), and I could only reproduce your error
once. My guess is that you're stopping the trial process before the hg serve
process is down. I'd suggest to:

add processEnded to MercurialPP, making that notify the TestCase. Something
like a deferred. And to return that from tearDown2.

Just guessing, as I only reproduced this once, and of course, I don't have
the logs of that anymore. Adding a log.msg to processEnded would make things
clearer still.

I ran your tests on both 1.1 and 0.9.5, any idea why 1.1 would take twice as
long to run through all 5 Mercurial tests? Almost a minute compared to less
than a half on my mac.

Axel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20090119/00f1776f/attachment.html>