[Buildbot-devel] step_status.setColor gone in git master, worth the breakage?

[Axel Hecht]

2009/2/25 Neil Hemingway <neil.hemingway at greyhavens.org.uk>

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> 2009/2/25 Dustin J. Mitchell <dustin at zmanda.com>
>
> It's not clear to me that a no-op (with attendant disappearance of
> color) is better than a traceback.  But I'm open to be convinced.
>
> The core buildbot code doesn't use the color attribute (hence my
> removing it).  All the HTML stuff used CSS classes based on the
> status, the only thing that still has color embedded is the guistatus
> gtk app.
>
> So the only reason that color should disappear for anyone if we stub
> out setColor(), is if their custom code doesn't also call setStatus()
>

FYI, the ticket is closed and we have a fill-in method now that writes to
the log.

I suggest that you try to remove your use of setColor() in your custom steps
nevertheless, I expect that wallpaper to be torn down in a future release.

Thanks

Axel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20090225/e4bdc945/attachment.html>