[Buildbot-devel] step_status.setColor gone in git master, worth the breakage?
neil.hemingway at greyhavens.org.uk
Wed Feb 25 18:26:45 UTC 2009
-----BEGIN PGP SIGNED MESSAGE-----
2009/2/25 Dustin J. Mitchell <dustin at zmanda.com>
It's not clear to me that a no-op (with attendant disappearance of
color) is better than a traceback. But I'm open to be convinced.
The core buildbot code doesn't use the color attribute (hence my
removing it). All the HTML stuff used CSS classes based on the
status, the only thing that still has color embedded is the guistatus
So the only reason that color should disappear for anyone if we stub
out setColor(), is if their custom code doesn't also call setStatus()
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
-----END PGP SIGNATURE-----
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the devel