[Buildbot-devel] step_status.setColor gone in git master, worth the breakage?

Dustin J. Mitchell dustin at zmanda.com
Wed Feb 25 17:21:21 UTC 2009

On Wed, Feb 25, 2009 at 12:08 PM, Axel Hecht <l10n.moz at googlemail.com> wrote:
> I just noticed that
> http://github.com/djmitche/buildbot/commit/d1190bd358845fe38204e89d8399f95a83309334#diff-7
> removed step_status.setColor. I have one step, and the mozilla guys have a
> flock of other steps, that don't take that change well.
> I wonder if we should keep that method as a no-op, or possibly log.msg()
> about it not doing anything anymore.
> Right now, it seems that custom steps need to make a call on whether they
> run up to 0.7.9 or on 0.7.10.

Hmm, is it *that* bad?  This is the problem with vague
"read-the-source-and-do-what-seems-best" APIs :(

It's not clear to me that a no-op (with attendant disappearance of
color) is better than a traceback.  But I'm open to be convinced.


Storage Software Engineer

More information about the devel mailing list