[Buildbot-devel] step_status.setColor gone in git master, worth the breakage?

[Neil Hemingway]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

That's not good.

I removed all the colour stuff as everything that cared set the status
anyway, and it was better to have the colour set by CSS classes (which
were already being set based on the status)

I have no problem with the method being stubbed out, but I wouldn't
want it to be reverted, as this gives the misleading impression that
it's useful.

I think it would probably be best to have it log.msg() that it's been
deprecated.

Is it just BuildStepStatus.setColor that's a problem or elsewhere (I
removed a bunch)?

Neil


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkmlfcQACgkQZjaLPuxR95Q8qgCeN1FKOIcsNoXZWDq56Pq8W9DB
kMcAoJoT9AFq5fuCBHIU18BryBM8RHXq
=WX+q
-----END PGP SIGNATURE-----
2009/2/25 Axel Hecht <l10n.moz at googlemail.com>

> Hi,
>
> I just noticed that
> http://github.com/djmitche/buildbot/commit/d1190bd358845fe38204e89d8399f95a83309334#diff-7removed step_status.setColor. I have one step, and the mozilla guys have a
> flock of other steps, that don't take that change well.
>
> I wonder if we should keep that method as a no-op, or possibly log.msg()
> about it not doing anything anymore.
>
> Right now, it seems that custom steps need to make a call on whether they
> run up to 0.7.9 or on 0.7.10.
>
> Axel
>
>
> ------------------------------------------------------------------------------
> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco,
> CA
> -OSBC tackles the biggest issue in open source: Open Sourcing the
> Enterprise
> -Strategies to boost innovation and cut costs with open source
> participation
> -Receive a $600 discount off the registration fee with the source code:
> SFAD
> http://p.sf.net/sfu/XcvMzF8H
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20090225/ac42370b/attachment.html>