[Buildbot-devel] duplicate steps problem

[Chris Rivera]

I've attached a patch that fixes this issue.  It converts stepnames from a
list to a hash that maps from step name to a counter.  It uses this hash to
append numbers to duplicate names instead of walking a list and counting
names on each iteration.  I tested this patch on my machine and I
successfully ran through the test suite.

Chris

On Fri, Apr 3, 2009 at 10:42 AM, Dustin J. Mitchell <dustin at zmanda.com>wrote:

> On Fri, Apr 3, 2009 at 9:17 AM, Brian Fallik <bfallik at litl.com> wrote:
> > What did you mean by "a very long waste of CPU cycles"?  Each build
> > step is responsible for some work.  If each one is a necessary phase
> > of the build, how is it a waste of CPU cycles?
> >
> > I did see that trunk contains an increase of this limit to 1000, but
> > I'm interested in why there is an arbitrary limit in the first place?
>
> The waste is in cycling through, potentially, a thousand already-used
> step names.  I wonder if a better solution isn't to keep some kind of
> step counter, and if a name is already in use, just append that
> number.  So if the second ShellCommand appears at index 5 in the
> factory, it would be named shell_5, rather than shell_2.
>
> A patch to fix this behavior would be great..
>
> Dustin
>
> --
> Storage Software Engineer
> http://www.zmanda.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20090403/bab746df/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: buildbot-fix-duplicate-steps.patch
Type: text/x-patch
Size: 1382 bytes
Desc: not available
URL: <http://buildbot.net/pipermail/devel/attachments/20090403/bab746df/attachment.bin>