[Buildbot-devel] Multiple change sources and scheduler issues

[Axel Hecht]

2008/7/23 Dustin J. Mitchell <dustin at zmanda.com>:
> On Wed, Jul 23, 2008 at 3:00 PM, Neil Hemingway
> <neil.hemingway at googlemail.com> wrote:
>> We already have schedulers setting Properties on builders, couldn't we
>> extend that to allow Changes to have Properties and then have those passed
>> on to the Build(Status) to be queried as needed?
>>
>> A callback on the ChangeSource could set whatever Properties it wants.
>> Another on Scheduler can tell on the scheduler whether it's interested in
>> this change (think of it as a generalization of the branch check)
>
> I like this!  It means Alex can use his dictionaries in a property of
> his devising, too!
>
> Dustin
>

I actually find the callback hard to grok. There are a few reasons for that:

- the change would need to know it's originating changesource
- instead of having static data associated with the change, it's runtime data
- There's a shutdown-flow-breaking cycle, AFAICT

I'd rather decorate the change itself with static data, which can be
persisted and resurrected.

I could just make them part of the properties, though. Walking
somewhat in a circle. They could just be a dict(), as I initially
planned, and we'd copy them over to the build objects as properties
from "Changes". Just not calling them colors, but properties.

If the theory about what the scheduler should do is too "interesting",
we can for now just make the scheduler do nothing about it. Maybe it's
cool enough for the Change class to have that ability, and then we can
play around and gather feedback with 0.7.9 to see what people actually
do with it?

Not sure if I should create some baseclass for our changesources to
add the properties as a generic configuration variable.

Axel