[Buildbot-devel] Error using WithProperties in ShellCommand description

[John Stile]

I am trying to add the branch and revision information from the Build
Properties into the waterfall (in buildbot-0.7.9), in the following way:
 
h = factory.BuildFactory()
h.addStep(shell.ShellCommand, 
          command=["/home/build/bin/build.bash",
                   "-b", WithProperties("%(branch)s"),
                   "-r", WithProperties("%(revision)s")],
          description=[WithProperties("%(branch)s")],
          descriptionDone=[WithProperties("%(branch)s:-trunk")]
         )

When i try to view the waterfall I get an Unhandled Error below.

Is there something wrong with my syntax?

The twistd.log error when accessing the waterfall:

2008-10-01 13:35:35-0700 [HTTPChannel,0,127.0.0.1] Unhandled Error
        Traceback (most recent call last):
          File "/usr/lib/python2.5/site-packages/twisted/protocols/basic.py", line 231, in dataReceived
            why = self.lineReceived(line)
          File "/usr/lib/python2.5/site-packages/twisted/web/http.py", line 1067, in lineReceived
            self.allContentReceived()
          File "/usr/lib/python2.5/site-packages/twisted/web/http.py", line 1108, in allContentReceived
            req.requestReceived(command, path, version)
          File "/usr/lib/python2.5/site-packages/twisted/web/http.py", line 626, in requestReceived
            self.process()
        --- <exception caught here> ---
          File "/usr/lib/python2.5/site-packages/twisted/web/server.py", line 150, in process
            self.render(resrc)
          File "/usr/lib/python2.5/site-packages/twisted/web/server.py", line 157, in render
            body = resrc.render(self)
          File "/usr/lib/python2.5/site-packages/buildbot/status/web/base.py", line 247, in render
            data = self.content(request)
          File "/usr/lib/python2.5/site-packages/buildbot/status/web/base.py", line 291, in content
            data += self.body(request)
          File "/usr/lib/python2.5/site-packages/buildbot/status/web/waterfall.py", line 530, in body
            sourceEvents)
          File "/usr/lib/python2.5/site-packages/buildbot/status/web/waterfall.py", line 974, in phase2
            data += b.td()
          File "/usr/lib/python2.5/site-packages/buildbot/status/web/base.py", line 199, in td
            return td(text, props, bgcolor=self.color, class_=self.class_)
          File "/usr/lib/python2.5/site-packages/buildbot/status/web/base.py", line 120, in td
            data += "<br />".join(text)
        exceptions.TypeError: sequence item 0: expected string, instance found