[Buildbot-devel] Merging buildrequests and custom build properties

Axel Hecht l10n.moz at googlemail.com
Thu May 22 16:03:15 UTC 2008

2008/5/22 Dustin J. Mitchell <dustin at zmanda.com>:
> On Thu, May 22, 2008 at 10:28 AM, Axel Hecht <l10n.moz at googlemail.com> wrote:
>> For the buildrequests, I'd propose to only merge if the source stamps
>> merge, and if the properties are the same.
> Thanks for the example.  I think I've got it.  Again, I'll take a more
> general approach: we find some way to specify a BuildRequest subclass
> in the configuration, and then you can write your own
> MozBuildRequest.canBeMergedWith.
> What do you think?

The problem I had was that the BuildRequest happens pretty far away
from the scheduler. Ben's hack for the sourcestamp is likely mine, and
that works OK if you really don't want to merge at all.

Another alternative would be to move the merge code from the
BuildRequest onto the Builder. Subclassing that is hard, probably as
hard as subclassing, but we could make it more configurable.

I don't know if I have a good reason, but I'd rather have sourcestamps
and buildrequests hidden, and possibly dumb.

Merging of BuildRequests feels like something up to the builder, too.

But that's gut feeling.


More information about the devel mailing list