[Buildbot-devel] Properties for build steps

Dustin J. Mitchell dustin at zmanda.com
Thu Jan 24 00:00:02 UTC 2008


On Jan 23, 2008 5:00 PM, Neil Hemingway <neil.hemingway at googlemail.com> wrote:
> I don't see a problem creating setStepProperty, getStepProperty etc. for the
> step and its status object, but it'll be a little confusing to then have
> setStepProperty and setProperty.  It would seem better to rename setProperty
> as setBuildProperty, but I suspect that would break existing code.

Good of you to worry over such a thing!

It's Brian's call exactly how this is handled, but I'll toss in a few pence.

I think that just changing the names would probably be fine,
particularly if a note to that effect goes into the next release
notes.  However, another option may be to define the functions with
the new names (and put the new names in the relevant interfaces), then
include e.g.,

  setProperty = setBuildProperty # be compatible with old function name

so as not to break old code.

Dustin

-- 
Storage Software Engineer
http://www.zmanda.com




More information about the devel mailing list