[Buildbot-devel] Get nothing doing WithProperties("%s", "revision") from a previously source.SVN(mode=export) step

Dossy Shiobara dossy at panoptic.com
Tue Apr 8 22:41:44 UTC 2008


On 2008.04.08, Dustin J. Mitchell <dustin at zmanda.com> wrote:
> I think that the fix would be to either parse the results of 'svn
> export', which ends with "Exported revision \d+"

Sounds good.

> or to run an 'svn info' against the repository before making the
> export (which introduces a small race condition)

The race condition only would happen if you do the svn export without
specifying the revision to export.  In the case where HEAD is requested,
you get the revision using "svn info" then export that explicit
revision.  In the case where a revision is requested, you export that
anyway.

This eliminates the race and closes this hole.


-- 
Dossy Shiobara              | dossy at panoptic.com | http://dossy.org/
Panoptic Computer Network   | http://panoptic.com/
  "He realized the fastest way to change is to laugh at your own
    folly -- then you can let go and quickly move on." (p. 70)




More information about the devel mailing list