[Buildbot-devel] Get nothing doing WithProperties("%s", "revision") from a previously source.SVN(mode=export) step

Dustin J. Mitchell dustin at zmanda.com
Tue Apr 8 18:45:56 UTC 2008


On Tue, Apr 8, 2008 at 1:54 PM, Dossy Shiobara <dossy at panoptic.com> wrote:
>  We need to change to having the build property container created before
>  the first build step.  Each build step should be able to read/write to
>  the properties container.
>
>  This way, the SVN step could store the version it checked out or
>  exported as a build property.  Downstream build steps could then get
>  and/or set/reset that property as needed.

That part's already set up -- the property is get_revision.  The
problem is that, on the slave side, buildbot runs 'svnversion' to
determine the revision it got.  Using an export, of course, svnversion
can't determine a revision, and gives nothing.

I think that the fix would be to either parse the results of 'svn
export', which ends with
Exported revision \d+
or to run an 'svn info' against the repository before making the
export (which introduces a small race condition)

I would certainly be in favor of a patch to implement either of those.

Dustin

-- 
Storage Software Engineer
http://www.zmanda.com




More information about the devel mailing list