[Buildbot-devel] FileUpload and wildcard support?

[Dustin J. Mitchell]

On Mon, Apr 7, 2008 at 3:30 PM, Dossy Shiobara <dossy at panoptic.com> wrote:
>  I've created a custom build step like above, but when it happens, it
>  never completes when skipped.  Here's the relevant code:
>
>     class CustomFileUpload(FileUpload):
>         def start(self):
>             scheduler = self.build.getProperty("scheduler")
>             if scheduler == "nightly":
>                 FileUpload.start(self)
>             else:
>                 self.step_status.setColor("green")
>                 self.step_status.setText(["upload", "skipped"])
>                 self.addCompleteLog("log", "skipped upload (not a nightly build, scheduler '%s')\n" % scheduler)
>                 # self.finished(SKIPPED)
>                 return SKIPPED

A brief look at the code suggests that this *should* work.  The same
construction is used in buildbot/steps/python_twisted.py.

Sounds like a bug, for sure.  Please file a bug, and if you can trace
it down to a fix, that'd be even better!

Dustin

-- 
Storage Software Engineer
http://www.zmanda.com