[Buildbot-devel] FileUpload and wildcard support?

[Dossy Shiobara]

On 2008.04.06, Greg Ward <gerg.ward+buildbot at gmail.com> wrote:
>   from buildbot.status.builder import SKIPPED
>   class SillyConditional(ShellCommand):
>       def start(self):
>           if self.getProperty("buildnumber") % 2 == 0:
>               # even build number: skip it
>               self.step_status.setColor("green")
>               self.step_status.setText(["skipped"])
>               return SKIPPED
>           else:
>               ShellCommand.start(self)

I've created a custom build step like above, but when it happens, it
never completes when skipped.  Here's the relevant code:

    class CustomFileUpload(FileUpload):
        def start(self):
            scheduler = self.build.getProperty("scheduler")
            if scheduler == "nightly":
                FileUpload.start(self)
            else:
                self.step_status.setColor("green")
                self.step_status.setText(["upload", "skipped"])
                self.addCompleteLog("log", "skipped upload (not a nightly build, scheduler '%s')\n" % scheduler)
                # self.finished(SKIPPED)
                return SKIPPED

You can see the build (right now) that's "stuck" in the
skipped-uploading step:

    http://gnashdev.org/buildbot/builders/gnash-win32-win2000/builds/44

It is the last build step.  At this point, the build should be
complete--but, if you look at the waterfall view:

    http://gnashdev.org/buildbot/waterfall?builder=gnash-win32-win2000

the upload step never seems to finish.  The build itself ends with the
"build successful" result, but that last skipped build step seems to not
record its completion time.

I'm guessing this is a Buildbot bug (and yes, this is with the latest
CVS HEAD of Buildbot code).  If anyone else agrees, I'll file it in Trac
as a bug.

-- 
Dossy Shiobara              | dossy at panoptic.com | http://dossy.org/
Panoptic Computer Network   | http://panoptic.com/
  "He realized the fastest way to change is to laugh at your own
    folly -- then you can let go and quickly move on." (p. 70)