[Buildbot-devel] SVN.parseGotRevision() patch
amax at snaplogic.org
Tue Oct 30 22:57:09 UTC 2007
Jean-Paul, you are correct that it's the revision number of the last change to
trunk I'm fishing for; I wasn't precise enough originally, thanks for
pointing it out.
I'm not sure if using the change notifier would work for us, since we need it
to work with arbitrary forced builds (i.e. old commits). Also, everything
works well already as it is, except for the revision number returned.
Charles, yeah, you're right, the default needs to be the old behavior.
Principle of least surprise.
Any other comments? I can make a new patch that makes this configurable.
On Tuesday 30 October 2007 14:03:49 you wrote:
> On 10/30/07, Aaron Maxwell <amax at snaplogic.org> wrote:
> > Perhaps some people will need the "svnversion ." behavior, and
> > some "svnversion -c .". If so, I could alter this so that it's
> > configurable.
> IMHO, it would be best if it were configurable, defaulting to the old
> behavior. It's a subtle enough change in semantics that people may not
> notice it when upgrading.
Aaron Maxwell .:. amax at snaplogic.org .:. http://snaplogic.org
SnapLogic, Inc. - Data Integration for the Last Mile
More information about the devel