[Buildbot-devel] bug in Change "links"

[Robert Helmer]

On 11/22/07, Robert Helmer <robert at roberthelmer.com> wrote:
>
> Hey,
>
> I just got 0.7.6 up and running and am testing it for Mozilla nightly
> releases (http://buildbot.roberthelmer.com)
>
> I am excited that Change now has a "links" list that can linkify changed
> files and started adding support for this to BonsaiPoller, but unfortunately
> it won't work with bonsai links as-is.
>
> buildbot/changes/changes.py:80
>             link = filter(lambda s: s.find(file) != -1, self.links)
>
> A BonsaiPoller-generated change might have a file name of:
> mozilla/accessible/src/base/nsAccessible.cpp
>
> However the corresponding Bonsai URL would be:
>
> http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/accessible/src/base&command=DIFF_FRAMESET&file=nsAccessible.cpp&rev1=1.337&rev2=1.338&root=/cvsroot
>
> Note the separation of "subdir" and "filename", so that filter will fail
> and the file will not be linkified :/
>
> Why not just insist that the files and links lists have the same number of
> elements, and use None for "no URL available" (seems like that'd be a very
> uncommon case, right?).



It would also be useful to have an "overall" link about the changeset
(bonsai attempts to collapse CVS checkins into changesets, or something like
that).

For example, the overall changeset would be:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&branch=HEAD&cvsroot=%2Fcvsroot&date=explicit&mindate=1195723264&maxdate=1195723367&who=reed%25reedloden.com

While the individual file+revision would be diff pages like:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/toolkit/mozapps/downloads/content&command=DIFF_FRAMESET&file=downloads.js&rev1=1.103&rev2=1.104&root=/cvsroot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20071122/d9feb337/attachment.html>