[Buildbot-devel] bug in Change "links"

Robert Helmer robert at roberthelmer.com
Thu Nov 22 08:59:30 UTC 2007


I just got 0.7.6 up and running and am testing it for Mozilla nightly
releases (http://buildbot.roberthelmer.com)

I am excited that Change now has a "links" list that can linkify changed
files and started adding support for this to BonsaiPoller, but unfortunately
it won't work with bonsai links as-is.

            link = filter(lambda s: s.find(file) != -1, self.links)

A BonsaiPoller-generated change might have a file name of:

However the corresponding Bonsai URL would be:

Note the separation of "subdir" and "filename", so that filter will fail and
the file will not be linkified :/

Why not just insist that the files and links lists have the same number of
elements, and use None for "no URL available" (seems like that'd be a very
uncommon case, right?).

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20071122/6ea9927d/attachment.html>

More information about the devel mailing list