[Buildbot-devel] FileUpload and FileDownload Binary Transfers

[Phil Thompson]

On Wednesday 07 March 2007 10:07 pm, Brian Warner wrote:
> Phil Thompson <phil at riverbankcomputing.co.uk> writes:
> > The FileUpload and FileDownload steps transfer files as text files - so
> > binary files transfered between Unix and Windows get corrupted.
>
> Huh? The transfer itself should be purely byte-oriented. Do you mean that
> the files on each end are opened as text-mode instead of binary mode?

Yes.

> > Is this a bug or a feature?
>
> It's a bug. Those steps should make a verbatim copy of the file on the
> target end. If someone has a need for this step to do some sort of text
> conversion along the way, maybe we can have a parameter to control that,
> but in the absence of such a need, I'd just make it binary-only. (I can
> imagine this needing more than one parameter to really be useful, and that
> could get complicated quickly).
>
> > I'm happy to submit a patch to either fix the bug, or enhance the feature
> > with another parameter to specify a binary transfer.
>
> That'd be great.. send it to me and I'll apply it.

Attached.

Phil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: buildbot-0.7.5-transfer.patch
Type: text/x-diff
Size: 1816 bytes
Desc: not available
URL: <http://buildbot.net/pipermail/devel/attachments/20070308/7cc0930e/attachment.bin>