[Buildbot-devel] FileUpload and FileDownload Binary Transfers

[Brian Warner]

Phil Thompson <phil at riverbankcomputing.co.uk> writes:

> The FileUpload and FileDownload steps transfer files as text files - so
> binary files transfered between Unix and Windows get corrupted.

Huh? The transfer itself should be purely byte-oriented. Do you mean that the
files on each end are opened as text-mode instead of binary mode?

> Is this a bug or a feature?

It's a bug. Those steps should make a verbatim copy of the file on the target
end. If someone has a need for this step to do some sort of text conversion
along the way, maybe we can have a parameter to control that, but in the
absence of such a need, I'd just make it binary-only. (I can imagine this
needing more than one parameter to really be useful, and that could get
complicated quickly).

> I'm happy to submit a patch to either fix the bug, or enhance the feature
> with another parameter to specify a binary transfer.

That'd be great.. send it to me and I'll apply it.

thanks,
 -Brian