[Buildbot-devel] properties in workdir, environment

[Axel Hecht]

Did you mean to use new_key in the second line?

+                new_key = self._interpolateProperties(key)
+                new_dict[key] = self._interpolateProperties(val)

Other than that, I just glanced over the patch so far, but that's one
thing I found. Any particular reason why you restricted the amount of
legal input values? I would have just returned the value for anything
not list, tuple, dict or WithProperties. Just guessing/asking.

Axel

2007/6/7, A.T.Hofkamp <a.t.hofkamp at tue.nl>:
> Hello all,
>
> A few days after having a workdir with WithProperties, I had the same problem
> with the environment variables, so I generalized the solution, and also fixed
> a todo in the process.
> I have attached the patch against ShellCommand of bb 0.7.5 .
>
> Could some body attach the patch to ticket #43 please?
>
> Albert
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
>
>
>