[Buildbot-devel] [PATCH 0/11] Patch series to enhance the WebStatus

[Benoit Sigoure]

On Nov 21, 2007, at 10:28 AM, Brian Warner wrote:

> I ran out of time tonight before getting to examine 9 through 12.  
> In general,
> I like the idea of being able to upload a diff to the web page, but  
> we have
> to be very very careful with this because anyone who can provide  
> the diff
> gets to control all the buildslaves.. that's why I've been using much
> stronger authentication mechanisms with the 'buildbot try' tool  
> than with
> regular force-build commands.
>
> Being able to use LDAP as an authentication backend is a nifty  
> idea. I assume
> that the library you're using is going to block, though, which  
> isn't quite in
> keeping with the rest of the twisted-based system (specifically if  
> the LDAP
> server takes more than a moment to respond, everything else in the
> buildmaster will be stuck waiting for it.. other waterfall users,  
> build
> scheduling, sending out slave commands, etc).
>
> Twisted has an authentication framework named 'Cred' that is partially
> supported by twisted.web and might be a more 'official' way to  
> implement
> password-protection on specific web pages. (by 'more official' I  
> mean more
> likely to be supported by other Twisted developers and libraries).  
> I haven't
> really used it much, though, so I couldn't say whether it is  
> suitable for
> this purpose. The ideal approach would be a Cred-based LDAP client,  
> but I
> don't even know if such a thing exists.


Hiya,
I'm afraid I won't have time to integrate my code better in Twisted,  
and as it often happens, I'm afraid the code will get lost.  So here  
is my proposal: why not apply my patches on HEAD and mention that  
it's still beta and add a FIXME or two to tell that more work needs  
to be done to use Twisted and everything.  I guess someone will  
tackle this issue later and, meanwhile, the code will be useful to  
others.

As a reminder, the related ticket is ticket #138 (http://buildbot.net/ 
trac/ticket/138) and the 4 last patches remain to be applied on the  
darcs "HEAD".

Cheers,

-- 
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory