[Buildbot-devel] Problems adding a SvnSource poller, one problem remaining

Brian Warner warner-buildbot at lothar.com
Tue Sep 12 18:36:33 UTC 2006


> After some sleep and a shower I knew where I made the main mistake.
> The attached patch (against the darcs repository) fixes except the
> one:

Excellent! Thanks for writing this. I'll take a look at the patch tonight.

> After a changes gets submitted the HTML waterfall responds with
> "Request did not return a string". Here is the Output if I click at 
> http://localhost:8081/changes/1:

Hm, is the problem that it's returning a unicode string instead of a
bytestring? I don't know if the twisted.web code is happy with unicode
objects.. you may need to encode it into utf-8 first and then make sure the
Content-Type (er, Content-Encoding?) is set to match. The first should be a
matter of returning 'foo.encode("utf-8")', but I don't know offhand how to do
the second.. I'll poke around and see what I can find.

Also, double-check that twistd.log isn't telling you anything useful.

thanks,
 -Brian




More information about the devel mailing list