[Buildbot-devel] Bonsaipoller test cases and Tinderbox patch

Robert Helmer robert at roberthelmer.com
Mon Nov 6 18:17:40 UTC 2006

Brian Warner wrote:
> Ben Hearsum <ben.hearsum at senecac.on.ca> writes:
>> The second one is more or less a rewrite of the BonsaiPoller module.
>> SF#1590310 -
> Applied. Thanks!
> I see that we still have that funny not-really-a-filename line:
>             for file in cinode.files:
>                 files.append(file.filename+' (revision '+file.revision+')')
> I remember that we were talking about this earlier, but I forget where we
> left it. Was there a way to get the information you want without creating
> Changes that have filenames that will confuse the tools that expect a pure
> filename?

Thanks for checking that in. Since "files" is just a list, I don't think 
there is a good way to do this without altering Changes. What we really 
need is for Changes to understand the idea that different files can have 
different revisions within the same Change.

One way to do this would be to allow a dict of filename/revision to be 
passed to revision, OR a list of files and one revision. There'd need to 
be some other modifications to Changes to support this, but it should be 
possible to preserve the current API so all callers aren't forced to change.

Let me know if this sounds like an acceptable solution, I can work 
something up.


More information about the devel mailing list