[Buildbot-devel] Bonsaipoller test cases and Tinderbox patch

Ben Hearsum ben.hearsum at senecac.on.ca
Sat Nov 4 03:14:15 UTC 2006


Hi,

I have submitted two patches to the SF page.

The first one is a small patch to the TinderboxMailNotifier that allows it to
send out "testfailed" status when it receives WARNINGS status. This patch was
written by Dave Liebreich.

SF#1587352 -
https://sourceforge.net/tracker/index.php?func=detail&aid=1587352&group_id=73177&atid=537003

The second one is more or less a rewrite of the BonsaiPoller module. I finally
got around to writing test_bonsaipoller.py. My original code was extremely
untestable and ugly -- so I re-wrote it. It has been thoroughly tested and
includes Rob Helmer's revision patch.

This patch applies cleanly to the current buildbot trunk.

SF#1590310 -
https://sourceforge.net/tracker/index.php?func=detail&aid=1590310&group_id=73177&atid=537003

Time permitting I will be writing test cases for the TinderboxMailNotifier in
the near future.

- Ben Hearsum

P.S. Did you see that I submitted a build commenting patch? SF#1575715. No
rush, just wanted to make sure you noticed it!




More information about the devel mailing list