[Buildbot-devel] CSS changes

Brian Warner warner-buildbot at lothar.com
Wed Apr 12 07:14:13 UTC 2006

> "This attribute assigns a class name or set of class names to an 
> element.  [...] Multiple class names must be separated by white space 
> characters."

Ok. So do we have any consensus as to what CSS attributes would be most useful?

Should we use class="command rebuild" so that CSS authors can control each
independently? In this case, about half of the patch would be dropped.

The patch in question also removes the class="table" attribute from the
<table>s. Was anybody using this class in their custom CSS?

My only other question about the remaining parts of this patch is the way it
changes the Waterfall page: previously, the project name/logo went into a
<tr> in the top-left corner of the table, whereas in the new version it goes
into a <div> before the table altogether. Granted, the <tr> was kind of
gross, but I think I like the name/logo going inside the table rather than
moving the table down the page to make room for some text above it.

Any thoughts?


More information about the devel mailing list