[Buildbot-devel] test_webPathname_port failure on win32

[Nick Trout]

I looked at some more of the tests and test_webPathname_port fails. I
had to add a time out to the deferred call or the test hangs and I have
to manually kill the tests. i.e. :- 

<<<<
@@ -151,7 +139,7 @@
         p = DistribTCP(dport)
 
         d = client.getPage("http://localhost:%d/remote/" % p.portnum)
-        page = dr(d)
+        page = dr(d, 3)
         #print page
         self.failUnless(page)
         dr(p.shutdown())
>>>>

If I run it like this I get the following warnings:

<<<<
test_waterfall (buildbot.test.test_web.WebTest) ... [OK]
test_webPathname (buildbot.test.test_web.WebTest) ... [SKIPPED]
test_webPathname_port (buildbot.test.test_web.WebTest) ...
C:\Python23\Lib\site-packages\twisted\web\distrib.py:176:
exceptions.Deprecation
Warning: This is deprecated. Use PBClientFactory.

C:\Python23\Lib\site-packages\twisted\web\server.py:122:
exceptions.DeprecationW
arning: IPv4Address.__getitem__ is deprecated.  Use attributes instead.

C:\Python23\Lib\site-packages\twisted\web\server.py:123:
exceptions.DeprecationW
arning: IPv4Address.__getitem__ is deprecated.  Use attributes instead.
[ERROR]
test_webPortnum (buildbot.test.test_web.WebTest) ... [OK]
>>>>

This seems to be because:

        dport = list(self.find_waterfall(m)[0])[0]._port.getHost().port

        p = DistribTCP(dport)

        d = client.getPage("http://localhost:%d/remote/" % p.portnum)

dport and p.portnum have different values (always 2 apart, i.e.
p.portnum = dport+2). I am assuming that these are supposed to be the
same value. If I make them the same value:

        d = client.getPage("http://localhost:%d/remote/" % dport)

The test just times out and fails. So, at a guess I'd say the following
code is perhaps not doing what it should?

        dport = list(self.find_waterfall(m)[0])[0]._port.getHost().port

Nick